-
Notifications
You must be signed in to change notification settings - Fork 744
Add Python 3.10 (build and test) #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
RE The error happens when it tries to install sentencepiece. Seemingly there is no binary distribution of sentencepiece on Windows for Python 3.10, so it falls back to source installation and fails. Googling the issue, I do not see an error reported, but I found this google/sentencepiece#591 which I assume @seemethere hit the same issue when adding 3.9 support. So we need to ask sentencepiece maintainer to publish 3.10 binary including Windows. Since sentencepiece is only an optional dependency, I think we can skip the tests and avoid installing sentencepiece. We will need to add some workaround to skip the tests that require sentencepiece. Once the installation of sentencepiece is conditioned on Python version and unit test starts running, then we can merge this PR and we can take over to follow-up on skipping part. |
|
RE This is an unexpected failure. I suspect there might be a regression about TorchScript on PyTorch core, as it is working on other versions. I suspect that the same failure will happen on Windows. |
|
closed and reopened to regenerate the tests |
|
To disable sentencepiece we need to add a check here for windows: audio/.circleci/unittest/linux/scripts/install.sh Lines 60 to 64 in bbdbd58
|
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere Just in case you have not heard, sentencepiece is an optional dependency, so ultimately you can ignore the test failures related to sentencepiece, as long as it builds fine. |
|
Although the test failure related to TorchScript on Tacotron2 seems like a real issue of PyTorch core on Python 3.10. I am planing to file a issue once this PR is merged. |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Should we just disable these tests for Python 3.10 in the interim? |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
|
So I found the reason why we need The This means that in order to actually install I'm including a commit here to enable |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
|
@seemethere has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
|
@seemethere has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @seemethere. |
Summary: Adding py3.10 to audio Pull Request resolved: pytorch#2224 Reviewed By: malfet, atalman, mthrok Differential Revision: D34442377 Pulled By: seemethere fbshipit-source-id: 2656de73427063958d609a74c01b526a476cb06a
|
Is the use of Python 3.10 still in development? When running torchaudio in my workflows, everything works fine for Windows and Ubuntu running 3.10, but with MacOS I get the following error. Thanks. |
Adding py3.10 to audio